Refactor TS integration and convert Camera to TS#1872
Refactor TS integration and convert Camera to TS#1872naftalibeder merged 104 commits intornmapbox:chore/typescriptfrom
Conversation
|
@mfazekas I also wanted to check about documentation - the Camera props are typed and |
|
@mfazekas Here's the current status: What's going well
What's not going well
So to make this ready for
I can't justify continuing to work on this non-stop, but it's really close, and I'm stuck on (1) above. It would be great if I could get a second pair of eyes. @mfazekas if you're okay with it, I'll merge it into a new |
|
@naftalibeder amazing, thank much! Yes feel free to merge it into a Doing |
Just to be clear, at least for me, the example works perfectly directly referencing the parent project. But I won’t believe it’s a perfectly stable way of doing it until I see a few more people do it successfully :) I mean the |
I've been wanting to do this for a while, because I think it will really speed up and simplify development work. This also changes the camera from a class to a functional component, and brings in modern memoization techniques.
It's a work in progress at the moment, but prop-based updates work perfectly.
Just re-implementing the imperative methods.Those are done too.Checklist